fix: 5554 - display of cached counts on user page #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `lazy_counter.dart`: Lazy Counter, with a cached value stored locally, and a call to the server. * `lazy_counter_widget.dart`: Widget displaying a Lazy Counter: cached value, refresh button, and loading. Impacted files: * `user_preferences.dart`: added methods about storing a lazy count value * `user_preferences_account.dart`: refactored the display of counts with the new `LazyCounter` and `LazyCounterWidget` classes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5573 +/- ##
==========================================
- Coverage 9.54% 6.96% -2.59%
==========================================
Files 325 402 +77
Lines 16411 21205 +4794
==========================================
- Hits 1567 1476 -91
- Misses 14844 19729 +4885 ☔ View full report in Codecov by Sentry. |
teolemon
approved these changes
Sep 11, 2024
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Files
New files:
lazy_counter.dart: Lazy Counter, with a cached value stored locally, and a call to the server.lazy_counter_widget.dart: Widget displaying a Lazy Counter: cached value, refresh button, and loading.Impacted files:
user_preferences.dart: added methods about storing a lazy count valueuser_preferences_account.dart: refactored the display of counts with the newLazyCounterandLazyCounterWidgetclasses